Skip to content

Conversation

l4mby
Copy link
Contributor

@l4mby l4mby commented Feb 8, 2024

No description provided.

Copy link
Member

@icappello icappello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@tarzacodes tarzacodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l4mby l4mby merged commit b7f8f16 into main Feb 12, 2024
@l4mby l4mby deleted the 186-explicit-close-should-not-emit-connection_closed branch February 12, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Explicit close of a publisher/consumer/client should not emit connection_closed

3 participants