fix: get default vhost if empty string is provided #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would prefer to get a validation error rather than an implicit fallback. |
dc1992
requested changes
Mar 24, 2025
l4mby
force-pushed
the
fix/215-rangeerror-err_buffer_out_of_bounds-attempt-to-access-memory-outside-buffer-bounds
branch
from
985f8fb to
2c45126
Compare
dc1992
approved these changes
Mar 28, 2025
l4mby
deleted the
fix/215-rangeerror-err_buffer_out_of_bounds-attempt-to-access-memory-outside-buffer-bounds
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.