nvim-cmp support

[eloycoto]

Hi!

Do you have plans to support nvim-cmp? At the moment is a bit intrusive(Because of the LSP), and it will be good to have the support natively, I'm struggling with cmp-tabnine on multi-line, and official support will be great.

The interface to add support is pretty easy, like:

local cmp = require('cmp')

local Source = {
}

function Source.new()
  last_instance = setmetatable({}, { __index = Source })
  last_instance:on_exit(0)
  return last_instance
end

function Source.is_available(self)
  return true
end

function Source.get_debug_name()
  return 'TabNine'
end


function Source.complete(self, ctx, callback)
  local input = string.sub(ctx.context.cursor_before_line, ctx.offset - 1)
  local prefix = string.sub(ctx.context.cursor_before_line, 1, ctx.offset - 1)

  local items = {}
  ---  Do tabnine magic here
  table.insert(items, {
    filterText = "TabNine magic here"
    label = "TabNine magic here",
    textEdit = {
      newText = "Tabnine magic here" ,
      range = {
        start = {
          line = ctx.context.cursor.row - 1,
          character = ctx.context.cursor.col - 1 - #input,
        },
        ['end'] = {
          line = ctx.context.cursor.row - 1,
          character = ctx.context.cursor.col - 1,
        },
      },
    },
  })


  callback({
    items = items,
    isIncomplete = true,
  })
end

cmp.register_source('cmp_tabnine', M.tabnine_source)

Here is an example video:
https://www.youtube.com/watch?v=gAsYolNrjtQ

And the code:
https://github.com/wincent/wincent/blob/91ebe56f414748078c93d011f5774553bddf3537/aspects/nvim/files/.config/nvim/lua/wincent/cmp/handles.lua

My idea is to have nvim with tabnine and LSP playing nice :-)

Happy to do contribution in a branch, and beta-testing :-)

[amirbilu]

Hi @eloycoto
Thanks for reaching out!
I'll definitely take a look into this

[amirbilu]

@eloycoto what would be the expected behavior in your opinion?
Tabnine completions are inline (virtual text) - This definitely better experience with multi-line suggestions.

[eloycoto]

@amirbilu with ghost text multiline is supported, no? Maybe @hrsh7th can provide some insights here.

https://github.com/hrsh7th/nvim-cmp/blob/10b1d11252cb106ab7416a51167e4e9af3f05598/doc/cmp.txt#L648

My ideal thing will be:

CMP by default, with tabnine enabled in there. like cmp-tabnine project. But getting inside current LSP is also super helpful.
On keymap, being able to use the current behaviour, like C^scape just give me an idea about what I need.

[amirbilu]

@eloycoto with cmp ghost text you still get the whole completion popup experience which is not optimal for multiline suggestions.

If you like short suggestions in the completion popup.. you can work with both plugins together

[arjes]

Just want to chime in to say that I would like to see this plugin provide a source from cmp too.

I do not want to use the provided virtual text because this plugin is fighting nvim-cmp over the virtual text content.

Take a look at how https://github.com/zbirenbaum/copilot-cmp integrates multi-line suggestions into the details text

[hrsh7th]

Hm... I don't use tabnine/copilot as a completion source for now.
(I think ghost text like appearance is best solution for those plugins)

[eloycoto]

@arjes +1, I'm using as it is, and It's totally unusable with both plugins :(

[amirbilu]

@eloycoto, @arjes I can add the option to not trigger Tabnine completions while the popup menu is visible - how does that sound?

[eloycoto]

@amirbilu great idea for me, Tabnine completations of, and cmp-support inside it! That will be the best thing for me. Something like this:

require('tabnine').setup({
  disable_auto_comment=true,
  accept_keymap=nil,
  disable_suggestion=true,
  debounce_ms = 300,
  suggestion_color = {gui = "#808080", cterm = 244},
  plugins = {
    cmp= true
  }
})

That for me will be great :-)

[arjes]

@hrsh7th I 100% agree with you that ghost text is the best solution for one of the biggest selling points of this plugin, but that case it just the selling point. It isn't the 99.5% usecase.

The usecase where ghost text completion shines is where it is filling out large portions of the functions/methods before I have started typing.

Once I start typing the ghost text is competing with my other completion sources which are likely more accurate (LSP).

So in my ideal usecase, I would want to see the ghost text provided by this plugin only when there is not a completion option otherwise being presented, once there are completion options I would prefer to see it offer it's completions there so I can review them. If simply making them go away and relying on cmp_tabnine for the cmp integration is what is required then that will work.

[amirbilu]

@arjes / @eloycoto let me know of what you think on this #7

[amirbilu]

Merged :)
Anything else or can I close this ticket?

[eloycoto]

Hi,

Just to make it clear, the current status is the following:

• If you want all line suggestions, using tabnine-nvim
• As soon you get cmp working, you need to switch to cmp-tabnine.

Am I correct?

[amirbilu]

Use tabnine-nvim to get inline, whole line & full function completions.

If you want to still have short Tabnine suggestions in the popup menu.. you can leave cmp tabnine on

[eloycoto]

Awesome, thanks!