Skip to content

Conversation

rupertnash
Copy link
Contributor

@rupertnash rupertnash commented Oct 5, 2021

My first go at a conformance test, based on bug reported in #749 (Fixes common-workflow-language/common-workflow-language#749 )

@rupertnash rupertnash requested a review from mr-c October 5, 2021 16:12
Copy link
Member

@mr-c mr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rupertnash
Copy link
Contributor Author

Sorry - terrible commit message! Please squash when happy!

@mr-c mr-c changed the title #749 test for nested directories and initial workdir requirement test for nested directories and initial workdir requirement Oct 6, 2021
@mr-c mr-c enabled auto-merge (squash) October 6, 2021 10:08
@rupertnash
Copy link
Contributor Author

I literally had just committed! Do we not need to add the hint to the CommandLineTool steps?

@mr-c
Copy link
Member

mr-c commented Oct 6, 2021

I literally had just committed!

Sorry!

Do we not need to add the hint to the CommandLineTool steps?

We could have added them there instead, but I was feeling lazy and working from the web interface. Since we need to rebase or merge anyhow, we could move the hint down to them for simplicity.

@mr-c mr-c merged commit a4e9f99 into common-workflow-language:1.2.1_proposed Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants