Adjust behavior of command_input_file_expression #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes it to reference another input parameter instead of using self. The behavior of processing secondary files patterns in order and being able to reference earlier ones later is not part of the spec. This doesn't exactly replicate the previous behavior, because it introduces a new input parameter, however it does demonstrate the ability to rename a file and have it staged as a secondary file without having to use InitialWorkDir. refs #127
mr-c
approved these changes
Oct 6, 2021
|
Yeah, I struggled with this test for toil-cwl-runner (by removing their hack and using more cwltool code): DataBiosphere/toil@34af4b3#diff-0de692d823906d36705d7d2c02a0bc99e191abc8b48f258401f9611184f339a2L3221 |
mr-c
added a commit
that referenced
this pull request
Oct 9, 2021
Changes it to reference another input parameter instead of using self. The behavior of processing secondary files patterns in order and being able to reference earlier ones later is not part of the spec. This doesn't exactly replicate the previous behavior, because it introduces a new input parameter, however it does demonstrate the ability to rename a file and have it staged as a secondary file without having to use InitialWorkDir. refs #127 Co-authored-by: Michael R. Crusoe <[email protected]>
kinow
pushed a commit
to kinow/cwl-v1.2
that referenced
this pull request
Oct 20, 2022
…guage#128) Changes it to reference another input parameter instead of using self. The behavior of processing secondary files patterns in order and being able to reference earlier ones later is not part of the spec. This doesn't exactly replicate the previous behavior, because it introduces a new input parameter, however it does demonstrate the ability to rename a file and have it staged as a secondary file without having to use InitialWorkDir. refs common-workflow-language#127 Co-authored-by: Michael R. Crusoe <[email protected]>
Just read #127, and this PR, and +1 that this solves #127, as this uses an input reference instead of accessing the array element (which relies on chance to work on different CWL implementations, as reported in the linked issue). |
GlassOfWhiskey
pushed a commit
that referenced
this pull request
Nov 15, 2023
Changes it to reference another input parameter instead of using self. The behavior of processing secondary files patterns in order and being able to reference earlier ones later is not part of the spec. This doesn't exactly replicate the previous behavior, because it introduces a new input parameter, however it does demonstrate the ability to rename a file and have it staged as a secondary file without having to use InitialWorkDir. refs #127 Co-authored-by: Michael R. Crusoe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes it to reference another input parameter instead of using self.
The behavior of processing secondary files patterns in order and being
able to reference earlier ones later is not part of the spec.
This doesn't exactly replicate the previous behavior, because it
introduces a new input parameter, however it does demonstrate the
ability to rename a file and have it staged as a secondary file
without having to use InitialWorkDir.
refs #127