Skip to content

make workflow output types optional; addresses #146, #147 #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 25, 2022
Merged

make workflow output types optional; addresses #146, #147 #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
000910a
make workflow output types optional; addresses #146, #147
jdidion Jan 24, 2022
056c221
Merge branch '1.2.1_proposed' into optional-wf-outputs
Jan 24, 2022
4e1ade2
validation warning won't be issued anymore
mr-c Jan 25, 2022
8ce1d1a
correct syntax for items field
mr-c Jan 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/conditionals/cond-wf-002.cwl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ steps:

outputs:
out1:
type: string
type: string?
outputSource: step1/out1

requirements:
Expand Down
2 changes: 1 addition & 1 deletion tests/conditionals/cond-wf-002_nojs.cwl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@ steps:

outputs:
out1:
type: string
type: string?
outputSource: step1/out1
2 changes: 1 addition & 1 deletion tests/conditionals/cond-wf-011.cwl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ outputs:
type: array
items:
type: array
items: string
items: [string, 'null']
outputSource: step1/out1
pickValue: all_non_null

Expand Down
2 changes: 1 addition & 1 deletion tests/conditionals/cond-wf-011_nojs.cwl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ outputs:
type: array
items:
type: array
items: string
items: [string, 'null']
outputSource: step1/out1
pickValue: all_non_null

Expand Down
2 changes: 0 additions & 2 deletions tests/conditionals/test-index.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@

- id: cond-3
label: direct_required
doc: Should give validation warning because of required sink
tool: cond-wf-002.cwl
job: val.1.job.yaml
output:
Expand Down Expand Up @@ -230,7 +229,6 @@

- id: cond-3_nojs
label: direct_required_nojs
doc: Should give validation warning because of required sink, no javascript
tool: cond-wf-002_nojs.cwl
job: val.1.job.yaml
output:
Expand Down