Skip to content

Conversation

@mr-c
Copy link
Member

@mr-c mr-c commented May 8, 2023

Closes: #240

@netlify
Copy link

netlify bot commented May 8, 2023

Deploy Preview for cwl-v1-2-dev ready!

Name Link
🔨 Latest commit 7fff829
🔍 Latest deploy log https://app.netlify.com/sites/cwl-v1-2-dev/deploys/6459183b5b191b00089e149b
😎 Deploy Preview https://deploy-preview-241--cwl-v1-2-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mr-c mr-c force-pushed the very_big_and_very_small branch from c9345b4 to 1fb1210 Compare May 8, 2023 15:23
@mr-c mr-c force-pushed the very_big_and_very_small branch from 1fb1210 to e08c96a Compare May 8, 2023 15:36
@mr-c mr-c requested a review from kinow May 8, 2023 15:37
@mr-c mr-c force-pushed the very_big_and_very_small branch from e08c96a to 7fff829 Compare May 8, 2023 15:41
@kinow
Copy link
Member

kinow commented May 8, 2023

Sorry was on mobile when leaving those comments and forgot to say that the tests for decimal look good to me. If the other changes are due to rebase/merge with other branches, we can merge and fix other things later 👍 Thanks!!

@mr-c
Copy link
Member Author

mr-c commented May 8, 2023

Sorry was on mobile when leaving those comments and forgot to say that the tests for decimal look good to me. If the other changes are due to rebase/merge with other branches, we can merge and fix other things later +1 Thanks!!

Which comments .. ?

@mr-c
Copy link
Member Author

mr-c commented May 8, 2023

The other changes are just some "spring cleaning"; technically unrelated

@mr-c mr-c merged commit 3d01afe into 1.2.1_proposed May 8, 2023
@mr-c mr-c deleted the very_big_and_very_small branch May 8, 2023 18:00
@kinow
Copy link
Member

kinow commented May 8, 2023

Sorry was on mobile when leaving those comments and forgot to say that the tests for decimal look good to me. If the other changes are due to rebase/merge with other branches, we can merge and fix other things later +1 Thanks!!

Which comments .. ?

s/comments/review feedback

## Introduction to v1.1

This is the third version of the Schema Salad specification. It is
This is the third version of of the Schema Salad specification. It is
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double of?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The terminology used to describe Salad documents is defined in the Concepts
section of the specification. The terms defined in the following list are
used in building those definitions and in describing the actions of a
used in building those definitions and in describing the actions of an
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An Salad? It may be github UI but I think it should be a?

## Document traversal

To perform document preprocessing, link validation and schema
To perform document document preprocessing, link validation and schema
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On github UI it is showing document duplicated?

## Short names

The "short name" of a fully qualified identifier is the portion of
The "short name" of an fully qualified identifier is the portion of
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A fully?

@kinow
Copy link
Member

kinow commented May 8, 2023

Aaaahh, I never submitted the review 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

very big & small floats/ints: never use scientific notation on the command line

3 participants