-
-
Notifications
You must be signed in to change notification settings - Fork 27
Add tests for decimal representation of very big and very small numbers #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for cwl-v1-2-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
c9345b4 to
1fb1210
Compare
1fb1210 to
e08c96a
Compare
e08c96a to
7fff829
Compare
|
Sorry was on mobile when leaving those comments and forgot to say that the tests for decimal look good to me. If the other changes are due to rebase/merge with other branches, we can merge and fix other things later 👍 Thanks!! |
Which comments .. ? |
|
The other changes are just some "spring cleaning"; technically unrelated |
s/comments/review feedback |
| ## Introduction to v1.1 | ||
|
|
||
| This is the third version of the Schema Salad specification. It is | ||
| This is the third version of of the Schema Salad specification. It is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double of?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The terminology used to describe Salad documents is defined in the Concepts | ||
| section of the specification. The terms defined in the following list are | ||
| used in building those definitions and in describing the actions of a | ||
| used in building those definitions and in describing the actions of an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An Salad? It may be github UI but I think it should be a?
| ## Document traversal | ||
|
|
||
| To perform document preprocessing, link validation and schema | ||
| To perform document document preprocessing, link validation and schema |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On github UI it is showing document duplicated?
| ## Short names | ||
|
|
||
| The "short name" of a fully qualified identifier is the portion of | ||
| The "short name" of an fully qualified identifier is the portion of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A fully?
|
Aaaahh, I never submitted the review 🤣 |
Closes: #240