Skip to content

Conversation

pvanheus
Copy link
Contributor

@pvanheus pvanheus commented Nov 24, 2020

This aims to address common-workflow-language/common-workflow-language#761 at least on the documentation level. The associated test should be expanded to ensure that incorrect usages are not allowed (e.g. $(null.something)).

@mr-c mr-c requested review from tetron and mr-c November 24, 2020 16:35
@pvanheus
Copy link
Contributor Author

This PR updates the text of the specification and also adds tests for some incorrect usages of parameter references.

@pvanheus
Copy link
Contributor Author

@mr-c and @tetron: are there rules for which tags should be specified for which conformance tests?

@mr-c
Copy link
Member

mr-c commented Nov 25, 2020

@pvanheus not written down.

There should be one of command_line_tool or workflow

If no optional parts like inline_javascript are used then it must be tagged required as well.

The above needs to be added to the conformance doc 😂

@mr-c mr-c enabled auto-merge (squash) November 26, 2021 10:06
@mr-c mr-c merged commit 236af6f into common-workflow-language:1.2.1_proposed Nov 26, 2021
kinow pushed a commit to kinow/cwl-v1.2 that referenced this pull request Oct 20, 2022
…anguage#64)

* Address ambiguity on null and inputs.somearray.length in parameter reference
* Clarify that the length field can sometimes apply to a non-array input
GlassOfWhiskey pushed a commit that referenced this pull request Nov 15, 2023
* Address ambiguity on null and inputs.somearray.length in parameter reference
* Clarify that the length field can sometimes apply to a non-array input
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants