Skip to content

New site preview #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 403 commits into from
Mar 2, 2022
Merged

New site preview #75

merged 403 commits into from
Mar 2, 2022

Conversation

mr-c
Copy link
Member

@mr-c mr-c commented Jul 6, 2021 •
edited
Loading

@mr-c
Copy link
Member Author

mr-c commented Jul 6, 2021

Here is the preview (though some of the links still point to commonwl.org) https://deploy-preview-75--cwl-website.netlify.app/

@lunacodes
Copy link
Contributor

The nav links are fixed for now (I commented out url: "https://www.commonwl.org" in _config.yml). It's not an ideal solution, since other plugins and functions often rely on the site.url variable.

A more ideal solution would be for jekyll to read an additional _config_staging.yml file, on this branch. Based on https://docs.netlify.com/configure-builds/file-based-configuration/ it looks like we can create a netlify.toml file in either the root or /site directory, and add the following, to it:

[context.new-site] # "new-site" is the branch name
  command = "jekyll build --config _config.yml,_config_staging.yml"

Afaict, the netlify.toml file should go in whatever the Base Directory is set to (in Site settings > Build & deploy > Continuous Deployment > Build settings).

@mr-c
Copy link
Member Author

mr-c commented Jul 8, 2021

Afaict, the netlify.toml file should go in whatever the Base Directory is set to (in Site settings > Build & deploy > Continuous Deployment > Build settings).

Base directory: content

@netlify
Copy link

netlify bot commented Jul 8, 2021 •
edited
Loading

✔️ Deploy Preview for cwl-website ready!

🔨 Explore the source changes: 3e2fe2a

🔍 Inspect the deploy log: https://app.netlify.com/sites/cwl-website/deploys/621db34e68ca5c00084e0c08

😎 Browse the preview: https://deploy-preview-75--cwl-website.netlify.app/features

@mr-c
Copy link
Member Author

mr-c commented Jul 9, 2021

Can the hypothesis.io parts only be activated when in the PR netlify preview? They are there just to get feedback from the community.

@mr-c
Copy link
Member Author

mr-c commented Jul 21, 2021

Preview of @lunacodes timeline: https://deploy-preview-75--cwl-website.netlify.app/timeline/ (not yet linked in)

@lunacodes
Copy link
Contributor

@mr-c is the Timeline supposed to get its own page and nav link, or is it integrated into one of the other pages?

@lunacodes
Copy link
Contributor

Nevermind - I just re-noticed the Timeline section on the About pg

@mr-c
Copy link
Member Author

mr-c commented Aug 25, 2021

@lunacodes @swzCuroverse Can you add https://github.com/common-workflow-language/common-workflow-language/wiki/Notable-CWL-mentions,-adoption,-and-users to the adopters page?

@mr-c
Copy link
Member Author

mr-c commented Aug 25, 2021

And then we can add logos and screenshots to spruce up the adopters list

@lunacodes lunacodes force-pushed the new-site branch 3 times, most recently from 3404178 to 2900fc5 Compare August 25, 2021 23:01
@lunacodes
Copy link
Contributor

lunacodes commented Aug 25, 2021 •
edited
Loading

@mr-c @swzCuroverse I added to content from the CWL Adopters wiki page. Let me know what you think.

Side note: sorry for all the force pushes before. I was trying to fix LGTM's merge warning/JS check failure (which I realized afterwards isn't something that can be done on my end). I don't think they'll cause any issues, but if they do it's probably easiest to just delete and re-clone the repo locally.

@michael-kotliar
Copy link

When resizing the window, at some moment the menu items are all grouped in the right top corner.
Screen Shot 2021-09-08 at 12 12 22 PM

@mr-c
Copy link
Member Author

mr-c commented Sep 8, 2021

We had a chat about the CWL Adopters page at the CWL meeting today, @lunacodes can you check out our notes https://docs.google.com/document/d/18Eo4qx7oDDOmD1IFlnUcIX0k955gzo6BNoMswxsh9bs/edit#bookmark=id.vinvmyqw76z4 and let us know how feasible this is?

@lunacodes
Copy link
Contributor

When resizing the window, at some moment the menu items are all grouped in the right top corner.
@michael-kotliar Thanks for the heads up. I'll have a fix up for that soon.

We had a chat about the CWL Adopters page at the CWL meeting today, @lunacodes can you check out our notes https://docs.google.com/document/d/18Eo4qx7oDDOmD1IFlnUcIX0k955gzo6BNoMswxsh9bs/edit#bookmark=id.vinvmyqw76z4 and let us know how feasible this is?
@mr-c seems perfectly feasible - I'll check in with @swzCuroverse for more specifics on the look/content.

@lunacodes lunacodes force-pushed the new-site branch 4 times, most recently from bbdfbbe to 03ea7f7 Compare November 16, 2021 00:17
kinow
kinow reviewed Dec 2, 2021
View reviewed changes
content/specification.md

* Peter Amstutz, Michael R. Crusoe, Nebojša Tijanić (editors), Brad Chapman, John Chilton, Michael Heuer, Andrey Kartashov, Dan Leehr, Hervé Ménager, Maya Nedeljkovich, Matt Scales, Stian Soiland-Reyes, Luka Stojanovic (2016):
Common Workflow Language, v1.0.
Specification, Common Workflow Language working group. <https://w3id.org/cwl/v1.0/> <https://doi.org/10.6084/m9.figshare.3115156.v2>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe include the ready-to-copy-and-paste examples for bibtex and other citation formats, as GitHub does? https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-citation-files

mr-c
mr-c commented Feb 17, 2022
View reviewed changes
@tetron
Copy link
Member

tetron commented Feb 17, 2022

To put on my leadership team hat for a minute, I am voting +1 on making this the new website for http://commonwl.org

@mr-c mr-c marked this pull request as ready for review February 18, 2022 17:50
@geoffjentry
Copy link
Contributor

👍

@tetron
Copy link
Member

tetron commented Feb 24, 2022 •
edited
Loading

@lunacodes we need to add back in the link anchors from the current page. Can go at the very bottom under "redirects from previous site" or similar. For example <a id="Implementations" href="/implementations/">#Implementations</a>

@mr-c
Copy link
Member Author

mr-c commented Mar 1, 2022

@lunacodes Can you turn off the hypothes.is integration? Or will that happen automatically on deployment to the production site?

@lunacodes
Copy link
Contributor

lunacodes commented Mar 1, 2022 via email

@mr-c
Copy link
Member Author

mr-c commented Mar 1, 2022

@tetron Fine by me to merge at any time

@mr-c mr-c merged commit 5506697 into main Mar 2, 2022
@mr-c mr-c deleted the new-site branch March 2, 2022 17:26
@lunacodes lunacodes mentioned this pull request Mar 25, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunacodes lunacodes lunacodes left review comments

@melibleq melibleq melibleq left review comments

@kinow kinow kinow approved these changes

+1 more reviewer

@swzCuroverse swzCuroverse swzCuroverse left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mr-c @lunacodes @michael-kotliar @swzCuroverse @tetron @geoffjentry @kinow @melibleq