Skip to content

Conversation

tom-tan
Copy link
Member

@tom-tan tom-tan commented May 23, 2022

It partially fixes #110 by adding deprecation messages for the following features:

  • use of label field,
  • use of id field with integers, and
  • lack of id field.

I also added a tentative deprecation deadline for these features (Currently it is 2023/1/1).
It makes easier for us to decide to remove these features in the future.

Note: it enables to check Deprecate label in the list in #110. We can already check If both label and id are present, then label will be used for messages. in the list.

@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #141 (9564970) into main (9672fa5) will increase coverage by 0.34%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
+ Coverage   60.04%   60.39%   +0.34%     
==========================================
  Files           2        2              
  Lines         453      457       +4     
  Branches      133      134       +1     
==========================================
+ Hits          272      276       +4     
  Misses        139      139              
  Partials       42       42              
Impacted Files Coverage Δ
cwltest/__init__.py 64.49% <100.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9672fa5...9564970. Read the comment docs.

@mr-c mr-c enabled auto-merge (squash) May 30, 2022 12:53
auto-merge was automatically disabled May 30, 2022 14:13

Head branch was pushed to by a user without write access

@tom-tan
Copy link
Member Author

tom-tan commented May 30, 2022

I added tests to improve coverage!

@mr-c mr-c merged commit 7fc2297 into common-workflow-language:main May 30, 2022
@mr-c
Copy link
Member

mr-c commented May 30, 2022

Thanks @tom-tan !

@tom-tan tom-tan deleted the deprecation-message branch May 30, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move label to id

3 participants