Skip to content

Conversation

tom-tan
Copy link
Member

@tom-tan tom-tan commented Jul 14, 2024

This request is to fix #216.

It was introduced by #209 due to missing the case with job field with explicit null value.
This request fixes it by adding the case with job: null in addition to the case of missing job field.

Copy link

codecov bot commented Jul 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.27%. Comparing base (12a0f7c) to head (1849dcb).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #217      +/-   ##
==========================================
+ Coverage   81.01%   81.27%   +0.25%     
==========================================
  Files           8        8              
  Lines         785      785              
  Branches      199      199              
==========================================
+ Hits          636      638       +2     
+ Misses        113      111       -2     
  Partials       36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mr-c mr-c merged commit 713f6e2 into main Jul 14, 2024
@mr-c mr-c deleted the fix-issue216 branch July 14, 2024 11:02
@mr-c
Copy link
Member

mr-c commented Jul 14, 2024

Thank you @tom-tan !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

recent release has broken CWL v1.2 conformance testing

2 participants