Skip to content

Conversation

@mr-c
Copy link
Member

@mr-c mr-c commented Oct 29, 2021

Fixes #1531
Fixes #1530

  • add test with a subworkflow and --single-process targetting a step of that sub-workflow, confirming that a hint or requirement from the grandparent workflow is inherited correctly.

@mr-c mr-c requested a review from jdidion October 29, 2021 17:33
@mr-c mr-c force-pushed the single_process_reqs_inherit branch from 2e01e81 to 8622080 Compare October 29, 2021 17:37
@codecov
Copy link

codecov bot commented Oct 29, 2021

Codecov Report

Merging #1558 (4af58ab) into main (8720230) will decrease coverage by 0.08%.
The diff coverage is 70.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1558      +/-   ##
==========================================
- Coverage   66.07%   65.99%   -0.09%     
==========================================
  Files          91       91              
  Lines       16155    16281     +126     
  Branches     4172     4218      +46     
==========================================
+ Hits        10674    10744      +70     
- Misses       4348     4389      +41     
- Partials     1133     1148      +15     
Impacted Files Coverage Δ
cwltool/argparser.py 89.77% <ø> (ø)
cwltool/builder.py 69.59% <ø> (-0.75%) ⬇️
cwltool/cwlviewer.py 98.85% <ø> (-0.02%) ⬇️
cwltool/main.py 64.86% <57.62%> (+2.81%) ⬆️
cwltool/software_requirements.py 67.53% <66.66%> (+0.42%) ⬆️
cwltool/subgraph.py 79.01% <74.50%> (-0.10%) ⬇️
cwltool/context.py 97.29% <100.00%> (ø)
cwltool/job.py 76.92% <100.00%> (ø)
cwltool/process.py 85.40% <100.00%> (ø)
cwltool/utils.py 79.70% <100.00%> (+0.94%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8720230...4af58ab. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Oct 29, 2021

This pull request introduces 2 alerts when merging 8622080 into 8720230 - view on LGTM.com

new alerts:

  • 1 for Unused import
  • 1 for Module-level cyclic import

@mr-c
Copy link
Member Author

mr-c commented Oct 29, 2021

Release test failure appears to be related to common-workflow-language/schema_salad#465

@mr-c mr-c changed the title --single-process inherit reqs & hints --single-process inherit reqs & hints; sub-workflows Oct 30, 2021
@mr-c mr-c force-pushed the single_process_reqs_inherit branch 2 times, most recently from 0dabecb to 42d2b91 Compare October 30, 2021 00:33
@lgtm-com
Copy link

lgtm-com bot commented Oct 30, 2021

This pull request introduces 4 alerts and fixes 1 when merging 42d2b91 into 8720230 - view on LGTM.com

new alerts:

  • 4 for Module-level cyclic import

fixed alerts:

  • 1 for Unused import

@mr-c mr-c force-pushed the single_process_reqs_inherit branch from 42d2b91 to 3c1595f Compare November 2, 2021 12:02
@lgtm-com
Copy link

lgtm-com bot commented Nov 2, 2021

This pull request introduces 4 alerts and fixes 1 when merging 3c1595f into 8720230 - view on LGTM.com

new alerts:

  • 4 for Module-level cyclic import

fixed alerts:

  • 1 for Unused import

@mr-c mr-c force-pushed the single_process_reqs_inherit branch from bd7e384 to 3ea5b06 Compare November 2, 2021 15:54
@mr-c mr-c marked this pull request as ready for review November 2, 2021 16:02
@lgtm-com
Copy link

lgtm-com bot commented Nov 2, 2021

This pull request introduces 3 alerts and fixes 1 when merging 3ea5b06 into 8720230 - view on LGTM.com

new alerts:

  • 3 for Module-level cyclic import

fixed alerts:

  • 1 for Unused import

@mr-c mr-c force-pushed the single_process_reqs_inherit branch from 56761c9 to a1159b4 Compare November 3, 2021 18:20
@lgtm-com
Copy link

lgtm-com bot commented Nov 3, 2021

This pull request introduces 3 alerts and fixes 1 when merging a1159b4 into 8720230 - view on LGTM.com

new alerts:

  • 3 for Module-level cyclic import

fixed alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Nov 3, 2021

This pull request introduces 3 alerts and fixes 5 when merging 4af58ab into 8720230 - view on LGTM.com

new alerts:

  • 3 for Module-level cyclic import

fixed alerts:

  • 4 for Module-level cyclic import
  • 1 for Unused import

@mr-c mr-c enabled auto-merge (squash) November 3, 2021 19:10
@mr-c mr-c merged commit 29d8279 into main Nov 3, 2021
@mr-c mr-c deleted the single_process_reqs_inherit branch November 3, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--single-process does not apply inherited requirements and hints --single-process does not work for steps in nested workflows

2 participants