Skip to content

Conversation

@tetron
Copy link
Member

@tetron tetron commented Nov 3, 2021

No description provided.

@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #1560 (9c65a7d) into main (29d8279) will increase coverage by 10.26%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1560       +/-   ##
===========================================
+ Coverage   55.73%   65.99%   +10.26%     
===========================================
  Files          46       91       +45     
  Lines        8164    16283     +8119     
  Branches     2074     4218     +2144     
===========================================
+ Hits         4550    10746     +6196     
- Misses       3072     4389     +1317     
- Partials      542     1148      +606     
Impacted Files Coverage Δ
cwltool/process.py 85.42% <100.00%> (ø)
cwltool/__init__.py 100.00% <0.00%> (ø)
cwltool/docker.py 68.99% <0.00%> (ø)
cwltool/command_line_tool.py 76.78% <0.00%> (ø)
cwltool/sandboxjs.py 74.59% <0.00%> (ø)
cwltool/workflow_job.py 55.08% <0.00%> (ø)
cwltool/argparser.py 89.77% <0.00%> (ø)
cwltool/errors.py 100.00% <0.00%> (ø)
cwltool/factory.py 90.90% <0.00%> (ø)
cwltool/resolver.py 71.92% <0.00%> (ø)
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29d8279...9c65a7d. Read the comment docs.

Copy link
Member

@mr-c mr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Can we get a test-case demonstrating the problem and that it is fixed?

@tetron tetron force-pushed the relocate-realpath branch from 0115ea9 to c46e406 Compare November 3, 2021 21:59
@tetron
Copy link
Member Author

tetron commented Nov 3, 2021

It took me way too long to write a test because the original case was pretty weird, it involves having the output directory also be part of the inputs but also symlinked.

@mr-c mr-c enabled auto-merge (squash) November 4, 2021 06:16
@mr-c mr-c merged commit d96ddbf into main Nov 4, 2021
@mr-c mr-c deleted the relocate-realpath branch November 4, 2021 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants