Skip to content

Conversation

@huzech
Copy link
Contributor

@huzech huzech commented Jan 17, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #1594 (7f22e42) into main (7a86924) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1594      +/-   ##
==========================================
+ Coverage   65.99%   66.07%   +0.07%     
==========================================
  Files          93       93              
  Lines       16469    16487      +18     
  Branches     4364     4370       +6     
==========================================
+ Hits        10869    10893      +24     
+ Misses       4442     4437       -5     
+ Partials     1158     1157       -1     
Impacted Files Coverage Δ
cwltool/argparser.py 89.82% <100.00%> (+0.04%) ⬆️
cwltool/context.py 97.29% <100.00%> (+0.01%) ⬆️
cwltool/docker.py 71.36% <100.00%> (+2.99%) ⬆️
job.py 62.32% <0.00%> (-0.20%) ⬇️
docker.py 49.37% <0.00%> (-0.20%) ⬇️
context.py 93.24% <0.00%> (+0.04%) ⬆️
argparser.py 76.23% <0.00%> (+0.10%) ⬆️
cwltool/command_line_tool.py 76.78% <0.00%> (+0.41%) ⬆️
cwltool/process.py 86.54% <0.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a86924...7f22e42. Read the comment docs.

@mr-c
Copy link
Member

mr-c commented Jan 17, 2022

Thanks @huzech ! In #984 we talked about this ; can you add a --no-strict-cpu-limit command line option to turn this off?

@mr-c mr-c changed the title add coresMin ResourceRequirement support docker: enforce cores ResourceRequirement by default Jan 17, 2022
@mr-c mr-c changed the title docker: enforce cores ResourceRequirement by default docker: enforce cores ResourceRequirement if requested Jan 17, 2022
Copy link
Member

@mr-c mr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just waiting for confirmation from the CI and then I will squash & merge

@mr-c mr-c merged commit f8f2404 into common-workflow-language:main Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants