-
-
Notifications
You must be signed in to change notification settings - Fork 237
fix --single-step step2_tool error #1597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1597 +/- ##
==========================================
- Coverage 66.29% 66.26% -0.04%
==========================================
Files 93 93
Lines 16503 16509 +6
Branches 4378 4380 +2
==========================================
- Hits 10941 10940 -1
- Misses 4408 4415 +7
Partials 1154 1154
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mypy is failing. But it also worked when I tried a --single-step $param for a workflow.
$ cat /tmp/params.json
{
"file1": {
"class": "File",
"location": "/tmp/foo.txt"
}
}
$ cwltool --debug --single-step step0 cwltool/schemas/v1.1/tests/count-lines11-extra-step-wf-noET.cwl /tmp/params.json
(...)
DEBUG Removing intermediate output directory /tmp/xrwwxp4z
DEBUG Removing intermediate output directory /tmp/7q408h7i
{
"output": {
"location": "file:///home/kinow/Development/python/workspace/cwltool/output",
"basename": "output",
"class": "File",
"checksum": "sha1$da39a3ee5e6b4b0d3255bfef95601890afd80709",
"size": 0,
"path": "/home/kinow/Development/python/workspace/cwltool/output"
}
}
INFO Final process status is success
|
Thank your test! I use list steps format in cwl, it's not work, I'll try to fix it with both list and object formt step |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @huzech for this. Can you add your test case to the PR so we can confirm the fix and prevent regressions in the future?
when use --single-step step2_tool parameter to run step in workflow meet this error
Traceback (most recent call last):
File "/d/project/cwltool-main/cwltool/main.py", line 1181, in main
ctool = choose_step(args, tool, loadingContext)
File "/d/project/cwltool-main/cwltool/main.py", line 861, in choose_step
extracted = get_step(tool, step_id, loading_context)
File "/d/project/cwltool-main/cwltool/subgraph.py", line 225, in get_step
name = outport.split("#")[-1].split("/")[-1]
AttributeError: 'CommentedMap' object has no attribute 'split'
when use --single-step step2_tool parameter to run step in workflow meet this error