Fixed race condition which happens when a job runs "too fast", #1890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a podman process finishes even before reaching the monitoring method, a deadlock happens, as no one is updating `process.returncode` and spawned process is in zombie state (so, no signal is sent). This fix adds a `process.poll()` call, so it gives the chance to fill in `process.returncode`.
Codecov Report
@@ Coverage Diff @@
## main #1890 +/- ##
==========================================
- Coverage 83.91% 80.43% -3.48%
==========================================
Files 46 46
Lines 8150 8152 +2
Branches 2169 2170 +1
==========================================
- Hits 6839 6557 -282
- Misses 842 1041 +199
- Partials 469 554 +85
|
|
Thank you @jmfernandez ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a podman process finishes even before reaching the monitoring method, a deadlock happens, as no one is updating
process.returncodeand spawned process is in zombie state (so, no signal is sent).This fix adds a
process.poll()call, so it gives the chance to fill inprocess.returncode.Fixes: #1883