patch dockerFile build #1979
Merged
patch dockerFile build #1979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1979 +/- ##
==========================================
- Coverage 83.85% 83.72% -0.14%
==========================================
Files 46 46
Lines 8245 8245
Branches 2190 2190
==========================================
- Hits 6914 6903 -11
- Misses 855 862 +7
- Partials 476 480 +4 ☔ View full report in Codecov by Sentry. |
mr-c
requested changes
Feb 27, 2024
There was a problem hiding this comment.
Thank you @misterbrandonwalker ; can you add a test to confirm this fix?
misterbrandonwalker
force-pushed
the
patch_dockerFile_build
branch
from
7611ad9 to
438db3c
Compare
mr-c
force-pushed
the
patch_dockerFile_build
branch
3 times, most recently
from
e900ab7 to
f7d2f34
Compare
mr-c
force-pushed
the
patch_dockerFile_build
branch
from
f7d2f34 to
f43df0f
Compare
|
Thank you @misterbrandonwalker ! |
|
[heart] Brandon Walker reacted to your message:
…________________________________
From: Michael R. Crusoe ***@***.***>
Sent: Wednesday, May 8, 2024 7:35:57 AM
To: common-workflow-language/cwltool ***@***.***>
Cc: Brandon Walker ***@***.***>; Mention ***@***.***>
Subject: Re: [common-workflow-language/cwltool] patch dockerFile build (PR #1979)
Thank you @misterbrandonwalker<https://github.com/misterbrandonwalker> !
—
Reply to this email directly, view it on GitHub<#1979 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKNB26N4DCKONW4CAQ2WQTTZBHIV3AVCNFSM6AAAAABD25AQUKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJZHEZTONBVGI>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't let dockerFile tag be dependent on force_pull or pull_image booleans