Replace .decode method with str(bytes, "utf-8") #1998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because some bytes-like objects (such as memoryview) don't have a "decode()" method. It appears that the preferred way to get a decoded string is to simply call the constructor with the bytes-like object and the desired encoding. Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1998 +/- ##
=======================================
Coverage 83.83% 83.83%
=======================================
Files 46 46
Lines 8245 8245
Branches 2190 2190
=======================================
Hits 6912 6912
- Misses 856 857 +1
+ Partials 477 476 -1 ☔ View full report in Codecov by Sentry. |
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <[email protected]>
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <[email protected]>
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <[email protected]>
|
I guess what it is telling me is that because I added tests, but the tests are not exhaustive of all lines/branches of the newly tested functions, the % total coverage actually went down. Argh. |
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <[email protected]>
mr-c
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because some bytes-like objects (such as memoryview) don't have a "decode()" method. It appears that the preferred way to get a decoded string is to simply call the constructor with the bytes-like object and the desired encoding.