Tests fixes for #48, includes #48 changes and fixes for #47 #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…les to the workflow need to be attached to a workflow_attachment. Thereby uploaded to a tem location for the server. workflow_url should always be assigned to the workflow descriptor file, as described by wes-schemas.
Closed
achave11-ucsc
changed the title
tetron
approved these changes
Aug 1, 2018
workflow_url could be any secondary file required by the workflow.
Member
|
From chat: This block is obsolete. The earlier definition of "workflow_descriptor" was for it to contain literal text but that was superceded by the multipart upload strategy. The code that saves the literal text from "workflow_descriptor" to a file should be removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making a different pr for the tests that contain fixes for the bugs reported and fixed in #48.
Included new test for checking workflow definition dependency.