Add function to determine a workflow's version. #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wfInfoAdd update dependencies
Wf info add
Unite test files.
Unite Test classes.
test/test_client_util.py
Outdated
| This test is run only on local files to avoid downloading and removing a new file. | ||
| """ | ||
|
|
||
| for format, location in self.local.items(): |
There was a problem hiding this comment.
Don't use the word format. format is a python builtin.
| import sys | ||
|
|
||
| from wes_client.util import expand_globs | ||
| pkg_root = os.path.abspath(os.path.join(os.path.dirname(__file__), '..')) # noqa |
There was a problem hiding this comment.
Please put this (lines 9 & 10) into the other test file as well.
test/test_client_util.py
Outdated
| self.assertEquals(wf_info(location[7:]), self.expected[format]) | ||
|
|
||
| else: | ||
| # Tests behavior after recieveing a non supported file type. |
Fix typo, bad var name. Add helpful testing lines.
DailyDreaming
approved these changes
Aug 16, 2018
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would add a function, and corresponding unit tests, for determining the version of a CWL, WDL or python-based workflow.