Move failing tests to the androidTest source-set as they interact with Fragment Lifecycle #6302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Generated APK variants! |
nicolas-raoul
approved these changes
May 9, 2025
Member
nicolas-raoul
left a comment
nicolas-raoul
left a comment
There was a problem hiding this comment.
Unit tests successful on both testDebug and prodRelease, app still working fine.
Thanks a lot!
sonalyadav1
pushed a commit
to sonalyadav1/apps-android-commons
that referenced
this pull request
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #6223
What changes did you make and why?
Since the
ContributionsListFragmentUnitTestsandBottomSheetLoggedOutFragmentUnitTestswere failing for prodRelease due toFragmentScenarionot being available for thereleasesource set. So, I moved those tests to theandroidTestsource set and added the dependency correctly as mentioned in the documentation.Tests performed (required)
Tested prodDebug, and prodRelease on Samsung A14 with API level 34.
Screenshots (for UI changes only)
None