The Upload Wizard's language drop-down now reflects the language used in the pin label. #6346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e pin's label is shown
|
✅ Generated APK variants! |
misaochan
approved these changes
Jun 11, 2025
nicolas-raoul
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
-Fixes an issue where the Upload Wizard’s language selection drop-down did not reflect the language in which the pin label is shown in Nearby.
-Previously, due to the language field not being set, the Upload Wizard defaulted to displaying "Basa Ugi" as the language, regardless of the actual pin label language.
Fixes #6191
What changes did you make and why?
-Adds the language parameter to the Place object in NearbyParentFragmentPresenter.kt.
language = repoPlace.languageTests performed (required)
Tested {build variant, ProdDebug} on {VIVO V25} with API level {34}.
Screenshots (for UI changes only)
video_20250611_110423_edit.mp4