-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Make "File usages" items clickable with correct URLs #6307 #6405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make "File usages" items clickable with correct URLs #6307 #6405
Conversation
|
Sorry my next 10 days are super busy, but we will come to this PR afterwards. Feel free to work on other bugs if you want. Thanks a lot for your patience! 🙂 |
Okay 👍🏻 |
@nicolas-raoul - Can you review my PR ? |
|
Links work great now, thanks a lot! I see domain names are now replaced with article name, which is good. The only small drawback is that for instance here we can't tell the difference between these articles: How about prefixing with for instance (en) or (fr) fr similar? Either in this PR, or I can create a new issue if you don't want to work on it. 🙂 |
|
✅ Generated APK variants! |
Can you please create a new issue for this? At the moment, I’m working on three Commons issues. I’ll get back to this one once I finish the tasks currently assigned to me in Commons. :) |
nicolas-raoul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working great, thanks!


This pull request fixes issue #6307 by making "Usages on Other Wikis" items clickable in the media details screen, opening the correct pages in the browser.
Changes:
FileUsagesUiModel.ktto generate correct URLs for other wikis (e.g.,https://en.wikipedia.org/wiki/Changi_East_Depot), handling full domains likeen.wikipedia.org.MediaDetailFragment.kt, with blue underlined text matching Commons usages.File:Changi_East_Depot_site_080525.jpgto ensure links work.Closes #6307.