Skip to content

Conversation

@rohit9625
Copy link
Collaborator

@rohit9625 rohit9625 commented Sep 6, 2025

Description (required)

Fixes #6412

What changes did you make and why?

  • After targeting SDK 35, we had to handle keyboard IME insets manually and push the input fields upwards. But I also added animations while pushing the content upwards when showing the keyboard in this PR Bump target sdk to API 35 and make the app UI compatible with edge to edge #6393.
  • Showing animations may require hardware acceleration on some devices, and we previously disabled the H/W acceleration for the UploadActivity, causing the Keyboard to not show on some devices and flickers while showing on some
  • So, I removed the hardwareAccelerated=false in the AndroidManifest.xml file for UploadActivity as it is enabled by default.
  • Along with that, added logic to handle IME insets at Depicts and UploadCategories step of Upload.

Tests performed (required)

Tested prodDebug on Samsung A14 and Pixel 6 Emulator with API level 35 and 31 respectively.

Screenshots (for UI changes only)

Pixel 6 Emulator(API 31):

Screen_recording_20250906_181712.webm

Copy link
Collaborator

@RitikaPahwa4444 RitikaPahwa4444 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't test it on a physical device but disabling makes sense. @pigsonthewing could you please try installing the prod debug apk generated above and see if it works for you?

@pigsonthewing
Copy link

try installing the prod debug apk generated above and see if it works for you

Mixed results. I can see the keyboard, but it overlays either the text entry field or the "next" button; see

https://commons.wikimedia.org/wiki/File:Commons_app_6-0-1-debug_showing_keyboard_bug_-_2025-09-06_-_01.jpg

https://commons.wikimedia.org/wiki/File:Commons_app_6-0-1-debug_showing_keyboard_bug_-_2025-09-06_-_02.jpg

@rohit9625
Copy link
Collaborator Author

Thanks for the review, @pigsonthewing. I'm fixing these issues 👍

@github-actions
Copy link

github-actions bot commented Sep 6, 2025

✅ Generated APK variants!

@rohit9625
Copy link
Collaborator Author

I resolved the overlapping button issues at the Depicts and Upload Categories step screen. However, I couldn't reproduce the issue where the keyboard was overlapping the input fields at the start of the Upload. Please retest the new APK, @pigsonthewing, and let me know if you can still reproduce that issue.

@pigsonthewing
Copy link

Please retest the new APK, @pigsonthewing, and let me know if you can still reproduce that issue.

All seems to be resolved now, including the input fields at the start of the upload. Thank you.

@rohit9625
Copy link
Collaborator Author

That's great :)
Thanks for your time, @pigsonthewing

Copy link
Collaborator

@RitikaPahwa4444 RitikaPahwa4444 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pigsonthewing for testing. The code looks good, thanks Rohit!

@RitikaPahwa4444 RitikaPahwa4444 merged commit 2811b18 into commons-app:main Sep 6, 2025
1 check passed
@rohit9625 rohit9625 deleted the fix/keyboad-issue branch September 12, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Keyboard does not show

3 participants