Replace Switch with SwitchMaterial #6522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lint recommended replacing Switch with SwitchMaterial. This was a very simple replacement, and I tested it in the custom selector, where it is used, and it works as it worked previously.
|
✅ Generated APK variants! |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Replaces the framework Switch with Material Components SwitchMaterial to align with lint recommendations and ensure consistent Material styling.
- Replace with <com.google.android.material.switchmaterial.SwitchMaterial> in XML layout
- Update Kotlin type and imports from android.widget.Switch to com.google.android.material.switchmaterial.SwitchMaterial
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/src/main/res/layout/fragment_custom_selector.xml | Replaces the widget tag to instantiate SwitchMaterial in the layout |
| app/src/main/java/fr/free/nrw/commons/customselector/ui/selector/ImageFragment.kt | Updates the import and property type to SwitchMaterial |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Lint recommended replacing Switch with SwitchMaterial. This was a very simple replacement, and I tested it in the custom selector, where it is used, and it works as it worked previously.