Skip to content

Adding slider-disabled class to container if input has disabled attribute. #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adding slider-disabled class to container if input has disabled attribute. #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e080a6
Adding slider-disabled class to container.
Sep 11, 2018
4b236cb
Tests for disabled slider.
Sep 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,9 @@ var Slider = {
classes.push("with-label")
else
classes.push("without-label")

if(slider.hasAttribute('disabled'))
classes.push('slider-disabled')

containerHTML = '<div class="'+classes.join(' ')+'" id="slider'+data.id+'">'
+ containerHTML
Expand Down
6 changes: 5 additions & 1 deletion test/server/sliders.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,8 @@

<label id='slider-9'>
<input type="range" max="4" data-label="a, b, c, d" data-label-a="1, 2, 3, 4" data-label-b="5, 6, 7, 8" data-before-label-a="a" data-after-label-a="a" data-before-label-b="b" data-after-label-b="b">
</label>
</label>

<label id='slider-10'>
<input id="disk" type="range" min="0" value="3" max="5" disabled="disabled">
</label>
7 changes: 7 additions & 0 deletions test/slider.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,4 +153,11 @@ describe('Slider', () => {

})

it('adds disabled class to the container when slider is disabled', async () => {
// when the slider input contains the disabled attribute,
// the container should have the 'slider-disabled' class
await u.findElement('#slider-10 [disabled="disabled"]')
await u.findElement(`.slider-container.slider-disabled`)
})

})