Default disable_ci_skip to true

[david-baylibre]

Is your feature request related to a problem? Please describe.

I think it would make sense to change disable_ci_skip default value to true for the following reasons:

• All filters are empty by default, disable_ci_skip introduces a filter in some way.
• On top of that, people do not benefit from PR fast check skipping repo download #425 which makes checks run instantly (skipping repo download), unless they set disable_ci_skip to true.

Describe the solution you'd like

Default disable_ci_skip variable to true

• OR -

Rename disable_ci_skip variable to enable_ci_skip (with default value set to false obviously)

Describe alternatives you've considered

No response

Additional context

I'd be happy to make a patch

[taylorsilva]

It would be nice to make this the default, but it will definitely break things for people who rely on the current default behaviour.

If you want to make this the default on your cluster you can take advantage of this feature: concourse/concourse#6079

So that way at least on your cluster, all git resources have disable_ci_skip set to true.

[taylorsilva]

Going through issues again. I don't see us making this change because it would be a breaking one. There have been other optimizations, so I'm comfortable leaving things as-is. Closing as not planned.