Skip to content

Schemaregistry examples (#69) #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Schemaregistry examples (#69) #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion schemaregistry/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@confluentinc/schemaregistry",
"version": "v0.1.17.4-devel",
"version": "v0.1.17.6-devel",
"description": "Node.js client for Confluent Schema Registry",
"main": "dist/index.js",
"types": "dist/index.d.ts",
Expand Down
10 changes: 5 additions & 5 deletions schemaregistry/rest-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,10 +101,10 @@ export class RestService {
delete this.client.defaults.auth;

const headers = ['logicalCluster', 'identityPoolId'];
const missingHeaders = headers.find(header => bearerAuthCredentials[header as keyof typeof bearerAuthCredentials]);
const missingHeader = headers.find(header => !(header in bearerAuthCredentials));

if (missingHeaders) {
throw new Error(`Bearer auth header '${missingHeaders}' not provided`);
if (missingHeader) {
throw new Error(`Bearer auth header '${missingHeader}' not provided`);
}

this.setHeaders({
Expand All @@ -127,14 +127,14 @@ export class RestService {
'issuerEndpointUrl',
'scope'
];
const missingField = requiredFields.find(field => bearerAuthCredentials[field as keyof typeof bearerAuthCredentials]);
const missingField = requiredFields.find(field => !(field in bearerAuthCredentials));

if (missingField) {
throw new Error(`OAuth credential '${missingField}' not provided`);
}
const issuerEndPointUrl = new URL(bearerAuthCredentials.issuerEndpointUrl!);
this.oauthClient = new OAuthClient(bearerAuthCredentials.clientId!, bearerAuthCredentials.clientSecret!,
issuerEndPointUrl.host, issuerEndPointUrl.pathname, bearerAuthCredentials.scope!);
issuerEndPointUrl.origin, issuerEndPointUrl.pathname, bearerAuthCredentials.scope!);
break;
default:
throw new Error('Invalid bearer auth credentials source');
Expand Down