Minor optimization to not derive schema when using existing schema #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
rayokota
commented
Nov 1, 2024
| schema = { | ||
| schemaType: 'AVRO', | ||
| schema: JSON.stringify(avroSchema), | ||
| } |
Member
Author
There was a problem hiding this comment.
This just puts the previous code in an if block
rayokota
commented
Nov 1, 2024
| schema = { | ||
| schemaType: 'JSON', | ||
| schema: JSON.stringify(jsonSchema), | ||
| } |
Member
Author
There was a problem hiding this comment.
This just puts the previous code in an if block
rayokota
commented
Nov 1, 2024
| this.config().useLatestWithMetadata == null) { | ||
| const fileDesc = messageDesc.file | ||
| schema = await this.getSchemaInfo(fileDesc) | ||
| } |
Member
Author
There was a problem hiding this comment.
This just puts the previous code in an if block
zhaochun-ma
approved these changes
Nov 1, 2024
zhaochun-ma
left a comment
zhaochun-ma
left a comment
There was a problem hiding this comment.
Thanks for the PR. would be great to add new test cases
airlock-confluentinc
bot
force-pushed
the
opt-lookup
branch
from
48c367b to
00e1048
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.