fix: memory leak in incremental assign #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milindl
reviewed
Apr 16, 2024
Co-authored-by: Milind L <[email protected]>
milindl
approved these changes
Apr 17, 2024
|
/sem-approve |
|
I didn't push properly, so the comments weren't added, but that is done now! |
|
@martijnimhoff it looks good to me. As this is our first external PR with code changes, there's a bunch of minor things I'm doing to get the CI to run on this once, and there should be a message from our CLA bot in a while on this PR for you. Thanks! |
|
Here's the link to the CLA that should be signed: https://cla-assistant.io/confluentinc/confluent-kafka-javascript?pullRequest=35 |
|
|
|
I've signed it. Should be fine now? |
|
/sem-approve |
|
Closing and reopening PR to try and trigger semaphore CI checks to run. |
|
/sem-approve |
|
Thanks @martijnimhoff for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The incremental assign contained a memory leak. This happened because when unassigning, the wrong new pointers are destroyed (m_partitions).
Instead the
partitionsargument should be destroyed, because this is only used to find the right toppars in m_partitions. And the toppars inm_partitionswhich are unassigned also should be destroyed.