Skip to content

Conversation

emasab
Copy link
Contributor

@emasab emasab commented Jul 31, 2025

As the rd_kafka_ResourceType_t is used for both ACLs and Config APIs in current major version, the values of ConfigResourceType that aren't present in ResourceType are mapped to higher integer values.

@Copilot Copilot AI review requested due to automatic review settings July 31, 2025 09:04
@emasab emasab requested a review from a team as a code owner July 31, 2025 09:04
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the remaining ResourceType and ConfigResourceType enum values to achieve complete mapping between the two enums. The changes enable proper handling of broker logger and client metrics configuration resources in the Kafka admin API.

  • Adds BROKER_LOGGER and CLIENT_METRICS enum values to both ResourceType and ConfigResourceType
  • Implements bidirectional mapping functions between the two enum types
  • Updates example code to support the new resource types

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/rdkafka_admin.h Adds new ConfigResourceType enum values and function declaration
src/rdkafka_admin.c Implements mapping functions and name resolution for new resource types
src/rdkafka.h Adds new ResourceType enum values with high integer mapping
examples/incremental_alter_configs.c Updates example to handle new resource type strings

@airlock-confluentinc airlock-confluentinc bot force-pushed the dev_remaining_resource_type_values branch 2 times, most recently from ec624f4 to 52bb123 Compare July 31, 2025 09:06
@emasab emasab marked this pull request as draft July 31, 2025 09:08
@airlock-confluentinc airlock-confluentinc bot force-pushed the dev_remaining_resource_type_values branch 2 times, most recently from a9b434a to 826ac27 Compare July 31, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant