Skip to content
This repository was archived by the owner on Mar 16, 2021. It is now read-only.

Conversation

tparikh
Copy link

@tparikh tparikh commented Nov 10, 2020

Signed-off-by: Tejas Parikh [email protected]

Copy link
Contributor

@brahmaroutu brahmaroutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let is agree amongst us about naming that is assumed here. image name and prefix 'cosi'.

@tparikh tparikh changed the title Added Kustomize for controller manager Added Kustomize for controller, sidecar & CRDs Dec 2, 2020
@tparikh tparikh requested review from brahmaroutu and rrati December 2, 2020 02:39
@tparikh
Copy link
Author

tparikh commented Dec 2, 2020

@wlan0 PTAL

Copy link

@NicolasT NicolasT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a bunch of comments. Some of them apply multiple times though I didn't add them at every occasion. Mainly:

  • Namespace handling
  • Common labels on objects

@tparikh
Copy link
Author

tparikh commented Dec 10, 2020

Closing this PR. The new PR is kubernetes-retired/container-object-storage-interface-controller#18

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants