Fixes #897: support env_file as objects
#925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GerkinDev
force-pushed
the
feat/env-file-object
branch
2 times, most recently
from
430ab27 to
1b02171
Compare
p12tic
requested changes
May 4, 2024
Collaborator
p12tic
left a comment
p12tic
left a comment
There was a problem hiding this comment.
Code looks good, thanks!
Could you add unit tests? There are a number of them already in pytests/test_container_to_args.py. It should be easy to extend them for the new options.
GerkinDev
force-pushed
the
feat/env-file-object
branch
2 times, most recently
from
03ad86b to
f4963f5
Compare
p12tic
force-pushed
the
feat/env-file-object
branch
from
f4963f5 to
88e4055
Compare
Fixes: containers#897 Signed-off-by: Alexandre Germain <[email protected]>
p12tic
force-pushed
the
feat/env-file-object
branch
from
88e4055 to
b202a09
Compare
p12tic
approved these changes
May 6, 2024
Collaborator
|
Rebased, joined all commits into one and adjusted commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
env_filebeing an object.requireddefaults toTrue