chore: update to github actions and npm trusted publishing #2800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelphamcf
approved these changes
Nov 14, 2025
Comment on lines
+74
to
+80
| - name: Get latest release tag | ||
| id: get-tag | ||
| run: | | ||
| TAG=$(gh api repos/${{ github.repository }}/releases/latest --jq .tag_name) | ||
| echo "tag=$TAG" >> $GITHUB_OUTPUT | ||
| env: | ||
| GITHUB_TOKEN: ${{ steps.vault.outputs.GITHUB_TOKEN }} |
Contributor
There was a problem hiding this comment.
I've just started noticing that this is not getting the correct tag for the summary in the next step.
https://github.com/contentful/contentful-management.js/actions/runs/19354829208#summary-55378237318
I'm putting together a PR in the OSS template that uses git describe instead to get the correct tag. https://github.com/contentful/open-source-project-template/pull/33/files
Can update now or wait til later since our other repos will need to be updated also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description
Motivation and Context
Checklist (check all before merging)
When adding a new method:
./lib/export-types.ts