-
Notifications
You must be signed in to change notification settings - Fork 947
Closed
Description
- What version of node
commitlintis currently supporting?
engines.node in most packages states 4, in root you can find 6 but some of dependencies require 8 and tests are executed on 8+. Should we align this? - Why so many different fs packages? maybe we should pick one and stick to it
What we should use? mayby we should just stick with fs and promisify?- cli tests are using
sanderhttps://www.npmjs.com/package/sander , no longer maintained - read is using
@marionebl/sanderhttps://www.npmjs.com/package/@marionebl/sander , fork of sander and no longer maintained - test is using
fs-extra(i introduced it as other had no types) - utils is using
@marionebl/sanderbut in different version
- cli tests are using
- Currently tests are creating a lot of temporary directories, but they never clean them up
tmphas mechanism to clean temporary files before program is closing, but due to isolation of jest it never gets triggered, than we have to call it manually
Metadata
Metadata
Assignees
Labels
No labels