Fix a bug when scrollview has content inset top 0 #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he refresh control to use the inset after the animation init to set as the original content inset.
…e width, to prevent it from clipping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the refresh control with scrollview with content inset top 0 (can cause by
self.edgesForExtendedLayout = UIRectEdgeNone;) will cause original content inset to be set as the content inset after the refresh control has started animating -> it will not go back to content inset 0. You can test it easily by comment out the line to setself.edgesForExtendedLayoutin the sample project. To fix it, only set self.originalTopContentInset when state is still Idle (no pull refresh has occurred)