Fix handling of completions when they don't go to the end of line #132
Conversation
Currently copilot.el assumes that the completion text will go all the way to the
end of the line. But this is not always the case. When this happens it
will lead to incorrectly deleting the text that used to be there. This will lead
to unbalanced parens or quotes.
The fix is to use the API's :end property to determine where the end of the
completed text should go.
Example:
text given to copilot
```python
print("hello |")
```
copilot will return the text `world`.
With the current implementation this will be the result if the user accepts the completion:
```python
print("hello world
```
After this PR, the result would be as expected:
```python
print("hello world")
```
|
Thanks for your work. You have solved a long-standing problem. I made some minor changes by refactoring the code and changing the meaning of the |
|
Thanks. I initially tried to use end as an absolute position like you did, but it doesn't work when you have automatic pair insertion (via smartparens, electric-pair-mode, cleverparens, etc). The issue is that if I insert |
|
Oh no, I haven't tested that case. I will revert my changes if there is a bug. |
|
Fixed in 7986e38 |
2 participants
Currently copilot.el assumes that the completion text will go all the way to the end of the line, but this is not always the case. When this happens it will lead to incorrectly deleting the text that used to be there. This will lead to unbalanced parens or quotes.
This PR fixes this by using the API's
:endproperty to determine where the end of the completed text should go.Example:
text given to copilot
copilot will return the text
world.With the current implementation this will be the result if the user accepts the completion:
After this PR, the result would be as expected:
This will resolve issues like #77 #62 #117