Skip to content

Bugfix/diagnose on unloaded buffer #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 5, 2023
Merged

Bugfix/diagnose on unloaded buffer #177

merged 2 commits into from
Sep 5, 2023

Conversation

@emil-vdw
Copy link
Collaborator

@emil-vdw emil-vdw commented Sep 2, 2023

Fix the error caused by copilot-diagnose as reported in #171 by:

  1. Activating copilot-mode for the current buffer if not already active.
  2. Make sure that the current buffer is loaded by the agent (didOpen notification has been sent).
  3. Use the current buffer's URI when making the test request instead of using an empty string as the URI.

@zerolfx zerolfx merged commit cebc411 into copilot-emacs:main Sep 5, 2023
@emil-vdw emil-vdw mentioned this pull request Sep 5, 2023
Open
raymond-w-ko pushed a commit to raymond-w-ko/copilot.el that referenced this pull request Sep 8, 2023
@emil-vdw @raymond-w-ko
Bugfix/diagnose on unloaded buffer (copilot-emacs#177)
8b0de79 
* Load and run diagnose request on current buffer URI

* Convert all tab indents to spaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emil-vdw @zerolfx