Skip to content

fix: Deprecated events-buffer-scrollback-size #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 8, 2024
Merged

fix: Deprecated events-buffer-scrollback-size #224

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
64a18e2
fix: Deprecated events-buffer-scrollback-size
AlexanderArvidsson Dec 29, 2023
d47c7c6
fix: Bump required jsonrpc to 1.0.23
AlexanderArvidsson Dec 29, 2023
db0b060
fix: Backwards compatibility with jsonrpc <1.0.23
AlexanderArvidsson Dec 30, 2023
9b100ac
fix: Simplify copilot--slot-exists-p
AlexanderArvidsson Dec 30, 2023
d00ba0d
fix: Optimize copilot--slot-exists-p with early return
AlexanderArvidsson Dec 30, 2023
2395161
fix: Revert back to #d47c7c6
AlexanderArvidsson Jan 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions copilot.el
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
;;; copilot.el --- An unofficial Copilot plugin for Emacs -*- lexical-binding:t -*-

;; Package-Requires: ((emacs "27.2") (s "1.12.0") (dash "2.19.1") (editorconfig "0.8.2") (jsonrpc "1.0.14"))
;; Package-Requires: ((emacs "27.2") (s "1.12.0") (dash "2.19.1") (editorconfig "0.8.2") (jsonrpc "1.0.23"))

;;; Code:
(require 'cl-lib)
Expand Down Expand Up @@ -154,7 +154,7 @@ Enabling event logging may slightly affect performance."
(setq copilot--connection
(make-instance 'jsonrpc-process-connection
:name "copilot"
:events-buffer-scrollback-size copilot-log-max
:events-buffer-config `(:size ,copilot-log-max)
:notification-dispatcher #'copilot--handle-notification
:process (make-process :name "copilot agent"
:command (list copilot-node-executable
Expand Down