Skip to content

Conversation

@bbatsov
Copy link
Collaborator

@bbatsov bbatsov commented Mar 30, 2025

The package uses a few external deps that are not really needed on modern Emacs:

  • s.el is easily replaced with built-in functions
  • dash is easily replaced with the built-in seq
  • f.el can also be replaced easily with built-in functions

When it comes to external deps, less is always more. :-)

@bbatsov bbatsov marked this pull request as draft March 30, 2025 13:39
@bbatsov bbatsov marked this pull request as ready for review March 30, 2025 14:15
@bbatsov
Copy link
Collaborator Author

bbatsov commented Mar 30, 2025

I've dropped s.el and dash.el, and there's only f-join left from f.el. Probably it'd be best to just inline it, as it's a pretty simple function, but we can do this down the road.

@zerolfx
Copy link
Collaborator

zerolfx commented Mar 30, 2025

I saw both (require 'subr-x.el) and (require 'subr-x) in code. Are they both correct?

@bbatsov
Copy link
Collaborator Author

bbatsov commented Mar 30, 2025

@zerolfx Seems I've made a silly typo. Just fixed it.

@zerolfx zerolfx merged commit ec2d61e into copilot-emacs:main Mar 31, 2025
10 checks passed
@viktorbezdek
Copy link

@bbatsov I guess the love for well written code never fades 🤘🏻

Hope you're doing great.

🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants