Substitute dummy parameters for nil in copilot requests #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This forces json serialisation to produce an object as an argument; previously, on some machines it would serialise `''nil` as `["quote", null]`. Fixes copilot-emacs#63
sandersn
deleted the
substitute-dummy-parameters-for-nil-copilot-requests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This forces json serialisation to produce an object as an argument; previously, on some machines it would serialise
''nilas["quote", null]. It seems that all messages expect an object for parameters; it's just expected to be empty for sign-in, sign-out and checking status.I don't know much about json serialisation in emacs, so it's possible that there's a way to configure jsonrpc differently, or that my setup has a bad combination of versions. This fix is more of a workaround.
Fixes #63