Validate empty labels in push #7052
Merged
+68
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SungJin1212
force-pushed
the
PRW2-add-label-validation
branch
from
21b09ab to
eb0be55
Compare
yeya24
reviewed
Oct 14, 2025
There was a problem hiding this comment.
I wonder why this validation is applied in convertV2RequestToV1. Isn't the same thing applied for V1 push logic?
We already have labels validation logic in
cortex/pkg/util/validation/validate.go
Line 281 in 5b7b4f5
pkg/util/push/push.go
Outdated
| lbs := v2Ts.ToLabels(&b, symbols) | ||
| // PRW2 spec allows UTF-8. | ||
| // c.f. https://prometheus.io/docs/specs/prw/remote_write_spec_2_0/#series-labels | ||
| if !lbs.Has(labels.MetricName) || !lbs.IsValid(model.UTF8Validation) { |
There was a problem hiding this comment.
We may need to check name validation scheme first? UTF-8 may not be enabled.
Or this validation will be applied later in distributor's push logic
|
I wonder if this is the right problem. I think the validation logic should apply for both v1 and v2 |
SungJin1212
force-pushed
the
PRW2-add-label-validation
branch
from
eb0be55 to
0d78022
Compare
SungJin1212
force-pushed
the
PRW2-add-label-validation
branch
from
0d78022 to
6badbc1
Compare
|
@yeya24 |
Signed-off-by: SungJin1212 <[email protected]>
SungJin1212
force-pushed
the
PRW2-add-label-validation
branch
from
6badbc1 to
a4389c5
Compare
|
Let's update the PR title. Now this change is not specific to PRW2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add label validations to Prometheus remote write 2.0
Which issue(s) this PR fixes:
Fixes #7043
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]