Skip to content

Ensure data.jsonrpc is a string to please no-base-to-string lint #1751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025
Merged

Ensure data.jsonrpc is a string to please no-base-to-string lint #1751

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/json-rpc/src/parse.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ export function parseJsonRpcRequest(data: unknown): JsonRpcRequest {
throw new Error("Data must be JSON compatible dictionary");
}

if (typeof data.jsonrpc !== "string") {
throw new Error(`Invalid "jsonrpc" field. Must be a string.`);
}
if (data.jsonrpc !== "2.0") {
throw new Error(`Got unexpected jsonrpc version: ${data.jsonrpc}`);
}
Expand All @@ -47,7 +50,7 @@ export function parseJsonRpcRequest(data: unknown): JsonRpcRequest {

const method = data.method;
if (typeof method !== "string") {
throw new Error("Invalid method field");
throw new Error(`Invalid "method" field. Must be a string.`);
}

if (!isJsonCompatibleArray(data.params) && !isJsonCompatibleDictionary(data.params)) {
Expand Down
Loading