Skip to content

Conversation

@almk-dev
Copy link
Contributor

@almk-dev almk-dev commented Jul 22, 2025

Description

Addresses: EVM-172

We found in the rpc package that some calls made to Tendermint RPC are not handled properly. In specific, the eth_getLogs rpc call when providing a blockHash.


Author Checklist

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the main branch

Reviewers Checklist

All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code
  • reviewed content
  • tested instructions (if applicable)
  • confirmed all CI checks have passed

@linear
Copy link

linear bot commented Jul 22, 2025

@almk-dev almk-dev changed the title fix: properly bubble up errors in BlockHash rpcs fix: properly bubble up errors in BlockHash rpcs and fix flaky tests Jul 22, 2025
@almk-dev almk-dev marked this pull request as ready for review July 22, 2025 16:43
@almk-dev almk-dev requested review from a team as code owners July 22, 2025 16:43
@aljo242
Copy link
Contributor

aljo242 commented Jul 23, 2025

@almk-dev conflicts

@aljo242 aljo242 added this pull request to the merge queue Jul 24, 2025
Merged via the queue into main with commit 099f44e Jul 24, 2025
16 checks passed
@aljo242 aljo242 deleted the evm-96-eth-getlogs-error-handling branch July 24, 2025 21:39
zsystm pushed a commit to zsystm/evm that referenced this pull request Nov 2, 2025
…osmos#330)

* add err returns

* fix test exp return

* fix flaky non padded copy

* add nil check for voting times

* use FillBytes instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants