Skip to content

Running make proto-all fails with protobuf lint error #1142

@damiannolan

Description

@damiannolan

Summary of Bug

Running make proto-all fails with protobuf lint error: "Enum value name \"...\" should be prefixed with \"RESPONSE_RESULT_TYPE_\"."

Steps to Reproduce

make proto-all
Formatting Protobuf files
{"path":"proto/ibc/core/channel/v1/tx.proto","start_line":50,"start_column":3,"end_line":50,"end_column":30,"type":"ENUM_VALUE_PREFIX","message":"Enum value name \"RESPONSE_RESULT_UNSPECIFIED\" should be prefixed with \"RESPONSE_RESULT_TYPE_\"."}
{"path":"proto/ibc/core/channel/v1/tx.proto","start_line":52,"start_column":3,"end_line":52,"end_column":23,"type":"ENUM_VALUE_PREFIX","message":"Enum value name \"RESPONSE_RESULT_NOOP\" should be prefixed with \"RESPONSE_RESULT_TYPE_\"."}
{"path":"proto/ibc/core/channel/v1/tx.proto","start_line":54,"start_column":3,"end_line":54,"end_column":26,"type":"ENUM_VALUE_PREFIX","message":"Enum value name \"RESPONSE_RESULT_SUCCESS\" should be prefixed with \"RESPONSE_RESULT_TYPE_\"."}
make: *** [proto-lint] Error 100

Proposal

Update the ResponseResultType enums to include _TYPE in the prefix.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned

Metadata

Metadata

Assignees

Labels

type: bugSomething isn't working as expected

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions