-
Notifications
You must be signed in to change notification settings - Fork 691
[fix][evaluation] kill expt #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5eb117a to
7c892b7
Compare
CozeLoop
reviewed
Nov 6, 2025
Collaborator
CozeLoop
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review completed. I've found a few issues, mostly related to error handling and logging. Please see the inline comments for details.
backend/modules/evaluation/domain/service/expt_manage_execution_impl.go
Outdated
Show resolved
Hide resolved
eb8e67d to
b78194a
Compare
dd0b40e to
5026499
Compare
HymanShi
reviewed
Nov 7, 2025
HymanShi
approved these changes
Nov 10, 2025
HymanShi
previously approved these changes
Nov 10, 2025
56a77ea to
1617318
Compare
fix(evaluation): BatchGetExperimentResult with sorted turn results fix(evaluation): BatchGetExperimentResult panic fix(evaluation): kill expt fix(evaluation): kill expt fix(evaluation): ut fix(evaluation): expt terminating for time cost fix(evaluation): ut
1617318 to
ea1c742
Compare
HymanShi
approved these changes
Nov 10, 2025
dsf86
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes:
Commit Details
c7564f52b4bd7c6444dec9440e6c65b0c2cb5d4bThis PR was automatically created from commit
c7564f52b4bd7c6444dec9440e6c65b0c2cb5d4b.