Skip to content

Conversation

@lsy357
Copy link
Collaborator

@lsy357 lsy357 commented Nov 3, 2025

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: [<type>][<scope>]: <description>. For example: [fix][backend] flaky fix
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Add documentation if the current PR requires user awareness at the usage level.
  • This PR is written in English. PRs not in English will not be reviewed.

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

Commit Details

  • SHA: c7564f52b4bd7c6444dec9440e6c65b0c2cb5d4b
  • Author: liushengyang [email protected]
  • Date: 2025-11-03 09:42:18

This PR was automatically created from commit c7564f52b4bd7c6444dec9440e6c65b0c2cb5d4b.

@lsy357 lsy357 force-pushed the feat/evaluation-expt-kill branch 2 times, most recently from 5eb117a to 7c892b7 Compare November 6, 2025 06:01
Copy link
Collaborator

@CozeLoop CozeLoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review completed. I've found a few issues, mostly related to error handling and logging. Please see the inline comments for details.

@lsy357 lsy357 force-pushed the feat/evaluation-expt-kill branch 3 times, most recently from eb8e67d to b78194a Compare November 6, 2025 08:02
@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 76.43312% with 37 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ation/domain/service/expt_manage_execution_impl.go 75.00% 7 Missing and 5 partials ⚠️
backend/modules/evaluation/pkg/conf/expt.go 0.00% 9 Missing ⚠️
...d/modules/evaluation/application/experiment_app.go 69.56% 3 Missing and 4 partials ⚠️
...on/domain/service/expt_run_scheduler_event_impl.go 57.14% 1 Missing and 2 partials ⚠️
...ules/evaluation/domain/service/expt_result_impl.go 95.83% 2 Missing ⚠️
...luation/domain/service/expt_run_item_event_impl.go 33.33% 0 Missing and 2 partials ⚠️
...evaluation/infra/repo/experiment/expt_repo_impl.go 0.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (76.43%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #285   +/-   ##
=======================================
  Coverage        ?   68.41%           
=======================================
  Files           ?      569           
  Lines           ?    51648           
  Branches        ?        0           
=======================================
  Hits            ?    35336           
  Misses          ?    13567           
  Partials        ?     2745           
Flag Coverage Δ
unittests 68.41% <76.43%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
backend/modules/evaluation/domain/entity/common.go 88.88% <ø> (ø)
backend/modules/evaluation/domain/entity/expt.go 96.66% <ø> (ø)
...ckend/modules/evaluation/domain/entity/expt_run.go 71.87% <100.00%> (ø)
backend/modules/evaluation/domain/entity/param.go 64.28% <100.00%> (ø)
...ules/evaluation/domain/service/expt_manage_impl.go 69.61% <100.00%> (ø)
...ion/domain/service/expt_run_scheduler_mode_impl.go 84.75% <100.00%> (ø)
...ules/evaluation/domain/service/expt_result_impl.go 74.82% <95.83%> (ø)
...luation/domain/service/expt_run_item_event_impl.go 82.11% <33.33%> (ø)
...evaluation/infra/repo/experiment/expt_repo_impl.go 80.95% <0.00%> (ø)
...on/domain/service/expt_run_scheduler_event_impl.go 75.55% <57.14%> (ø)
... and 3 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 280027e...ea1c742. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lsy357 lsy357 force-pushed the feat/evaluation-expt-kill branch 2 times, most recently from dd0b40e to 5026499 Compare November 6, 2025 13:03
HymanShi
HymanShi previously approved these changes Nov 10, 2025
@lsy357 lsy357 force-pushed the feat/evaluation-expt-kill branch 5 times, most recently from 56a77ea to 1617318 Compare November 10, 2025 07:47
fix(evaluation): BatchGetExperimentResult with sorted turn results

fix(evaluation): BatchGetExperimentResult panic

fix(evaluation): kill expt

fix(evaluation): kill expt

fix(evaluation): ut

fix(evaluation): expt terminating for time cost

fix(evaluation): ut
@lsy357 lsy357 force-pushed the feat/evaluation-expt-kill branch from 1617318 to ea1c742 Compare November 10, 2025 08:18
@lsy357 lsy357 merged commit 03abb4a into main Nov 10, 2025
13 checks passed
@lsy357 lsy357 deleted the feat/evaluation-expt-kill branch November 10, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants