[fix][evaluation] BatchGetExperimentResult with sorted turn results #296
+17
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(evaluation): BatchGetExperimentResult panic
CozeLoop
reviewed
Nov 7, 2025
Collaborator
CozeLoop
left a comment
CozeLoop
left a comment
There was a problem hiding this comment.
One issue identified: potential loss of duplicate entries when ordering experiment builders by ExptIDs; see inline comment.
Comment on lines
+892
to
+898
| resultedBuilders := make([]*ExptResultBuilder, 0, len(exptIDToResultBuilder)) | ||
| for _, exptID := range b.ExptIDs { | ||
| if got := exptIDToResultBuilder[exptID]; got != nil { | ||
| resultedBuilders = append(resultedBuilders, exptIDToResultBuilder[exptID]) | ||
| } | ||
| } | ||
| b.ExptResultBuilders = resultedBuilders |
Collaborator
There was a problem hiding this comment.
[P2] Potential loss of duplicate entries when ordering builders by ExptIDs. Using a map keyed by ExptID collapses duplicates if b.ExptIDs contains repeated IDs. The previous slice-based approach preserved duplicates; the new logic will drop them silently. If duplicates are possible at input (client/aggregation bugs do happen), this changes behavior and may produce fewer experiment results than expected. Consider preserving duplicates by ordering the existing slice stably according to b.ExptIDs instead of re-building from a map:
rank := make(map[int64]int)
for i, id := range b.ExptIDs { rank[id] = i }
sort.SliceStable(exptResultBuilders, func(i, j int) bool { return rank[exptResultBuilders[i].ExptID] < rank[exptResultBuilders[j].ExptID] })
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
fix(evaluation): BatchGetExperimentResult panic
zh(optional):
(Optional) Which issue(s) this PR fixes:
Commit Details
8d21c20eed75b357e87cb4bed83e7bde91d8eadeThis PR was automatically created from commit
8d21c20eed75b357e87cb4bed83e7bde91d8eade.