Skip to content

Conversation

@surister
Copy link
Member

@surister surister commented Mar 7, 2024

About

Illustrate how to use Apache Flink through its PyFlink interface, together with Apache Kafka and CrateDB.

Copy link
Member

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent job, I love it.

@surister surister marked this pull request as ready for review March 10, 2024 19:55
@surister surister force-pushed the streaming-kafka-flink branch 2 times, most recently from 1bee60d to df13db1 Compare March 12, 2024 16:54
@surister surister force-pushed the streaming-kafka-flink branch from df13db1 to a11deb1 Compare March 12, 2024 16:56
Copy link
Member

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent patch, thank you very much. Just added some comments/suggestions about a few nits, and also adding @matriv as reviewer.

@amotl amotl requested a review from matriv March 13, 2024 06:16
Copy link
Contributor

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx a lot for this effort @surister !

Left a couple more comments on top of the ones posted by @amotl .

Copy link
Member

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a few minor suggestions which could be adjusted, approving this. Thanks again!

@surister surister merged commit 5aadb16 into crate:main Mar 15, 2024
@surister
Copy link
Member Author

Thanks for the thorough review, all fixes have been applied 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants