Skip to content

[Gemspec] - Allow lower faraday versions #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 20, 2025

Conversation

itstheraj
Copy link
Contributor

@itstheraj itstheraj commented May 14, 2025

Description

In reference to issue: #172 - this CR exists to allow for applications requiring different, lower Faraday versions to integrate with this Gem.

Changes Made

  1. Updated the gemspec for Faraday and its dependencies to allow use of lower versions in case of a conflict.
  2. Updated CICD.yml workflow to validate that lower Faraday versions work.
  3. Specs failed on lower Faraday versions so I updated lib/ruby_llm/streaming.rb to allow for legacy Faraday versions to stream responses as well. Could use feedback definitely in case this breaks logic in a way you all are uncomfy with.

Testing

I ran manually rspec with Faraday Version 2.13.1 and 1.10.3, here are the results prior to CI/CD integration in this repo:

Faraday Version Validate Gem Install Test Results
1.10.3 Screenshot 2025-05-14 at 12 52 57 PM Screenshot 2025-05-14 at 12 53 03 PM
2.13.1 Screenshot 2025-05-14 at 12 52 39 PM Screenshot 2025-05-14 at 12 52 46 PM

@itstheraj itstheraj marked this pull request as ready for review May 14, 2025 18:34
@itstheraj itstheraj marked this pull request as draft May 14, 2025 18:35
@itstheraj itstheraj marked this pull request as ready for review May 14, 2025 20:05
@itstheraj itstheraj force-pushed the allow-lower-faraday-versions branch 3 times, most recently from 57485b0 to 63da2c3 Compare May 15, 2025 20:16
@itstheraj itstheraj force-pushed the allow-lower-faraday-versions branch from 63da2c3 to 9be4954 Compare May 19, 2025 16:34
Copy link

codecov bot commented May 20, 2025

Codecov Report

Attention: Patch coverage is 69.23077% with 8 lines in your changes missing coverage. Please review.

Project coverage is 91.06%. Comparing base (8b16d38) to head (df46d16).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/ruby_llm/streaming.rb 69.23% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #173      +/-   ##
==========================================
- Coverage   91.29%   91.06%   -0.23%     
==========================================
  Files          91       91              
  Lines        3641     3661      +20     
  Branches      559      567       +8     
==========================================
+ Hits         3324     3334      +10     
- Misses        317      327      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@crmne crmne merged commit d11c731 into crmne:main May 20, 2025
7 checks passed
@itstheraj itstheraj deleted the allow-lower-faraday-versions branch May 20, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants