Fix: Add resolve method delegation from Models instance to class #407
+44
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
resolve
instance method that delegates to the class methodRubyLLM.models.resolve
in the migration templateContext
The upgrade migration template at
lib/generators/ruby_llm/upgrade_to_v1_7/templates/migration.rb.tt
usesRubyLLM.models.resolve
on lines 74 and 139. However,RubyLLM.models
returns aModels
instance, which didn't have theresolve
method - it was only available as a class method.Changes
resolve
instance method inModels
class that delegates toself.class.resolve
assume_exists
option for unknown modelsTest plan
bundle exec rspec spec/ruby_llm/models_spec.rb -e resolve
- all tests passRubyLLM.models.resolve
without errors🤖 Generated with Claude Code